fallback to Scheduler if the GRID is not available on runtime#1473
Merged
Conversation
rvhonorato
added
the
execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.mdis updated to incorporate new changesSummary of the Pull Request
This PR adds a fallback to
get_engineto check if the GRID connection is possible before returningGRIDScheduler.The fallback logic is to call
libgrid.ping_diracthat will check if the necessary commands are available in the PATH and also rundirac-proxy-infothat will return a non-zero code if the connection has not been made.The behavior is then: if an user sets
mode=gridbut the grid is not available, it will use the local processors instead of the grid, inhering whateverncoreswas defined in the configuration file and also display a warning in the logs.The check will be done per-module, so it should capture the scenario in which one module can finish with the grid but for some reason it becomes unavailable, the following will then use the multiprocessing scheduler. This should give is a higher execution fault tolerance.
Related Issue
#1472